search

smartxworks / virtink

Lightweight Virtualization Add-on for Kubernetes
Apache License 2.0
492 stars 41 forks source link

fix: Update CH openapi manifest URL #83

Closed carezkh closed 1 year ago

carezkh commented 1 year ago

When the field Vcpu is 0, golang JSON encoder will ignore it, causing field vcpu missing in output file. So we should make field Vcpu required in CpuAffinity https://github.com/smartxworks/virtink/blob/d7d5162c2d9fc3edc6ea264e58336d212d1fd752/pkg/cloudhypervisor/client.go#L752-L755

I have updated CH openapi manifest file, see patch. Currently we can use the openapi yaml in this commit, and nothing else has be changed compared to CH release v28.0

codecov[bot] commented 1 year ago

Codecov Report

Merging #83 (7f6791d) into main (d7d5162) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   34.78%   34.78%           
=======================================
  Files           6        6           
  Lines        1912     1912           
=======================================
  Hits          665      665           
  Misses       1143     1143           
  Partials      104      104

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fengye87 commented 1 year ago

@carezkh The CH PR you mentioned has been merged, please change back the manifest URL and re-generate code