smcnally / office_quiz

A personality quiz based off of characters from The Office
https://tcasey.github.io/office_quiz
MIT License
0 stars 0 forks source link

Rt issue 16 #17

Closed rogertheriault closed 6 years ago

rogertheriault commented 6 years ago

This should help with issue #16

To switch back and forth, change the App class list from constrain-300x600 to unconstrained

I've not had a chance to test with a variety of iframes

smcnally commented 6 years ago

Constraining the tool UI to 300x600 helps points out where else style changes & re-flows have to happen. We need to make updates to

container
imgQuestion
multiQuestion
nextButton 
nextInstructions
answerOptionImage
coolMatrix

container is 285px, so anything wider causes h-scrolling. image

at 300px, imgQuestion overflows image

img coming in actual size is OK here*. items in imgQuestion should be v and h centered / middle

(* - imqQuestion imgwill conform to 300x250 standard for consistency. Other thanimqQuestion img -- e.g. successImg and images referenced in dangerouslySetHTML can be actual-size though no larger than 300x250. Can create another ticket referencing this one.)

image

nextButton on multis causes overflows. Perhaps we have nextButton in nextInstructions for question multiQuestion imgQuestion and allow question copy full-width?

I'll tweak the instructions copy and button min-height

image

related: answerOptionImage for coolMatrix should have their own constraints -- 150x125 ? -- otherwise we'll get a coolVerticalList vs a matrix / grid. (Can create another ticket referencing this one.)

image

rogertheriault commented 6 years ago

I made some changes that should resolve all the issues above.

image

image

image