search

smerckel / dbdreader

A reader for binary data files created by Slocum ocean gliders (AUVs)
GNU General Public License v3.0
16 stars 14 forks source link

Added cacheDir to DBDPatternSelect.select #17

Closed hawesie closed 1 year ago

hawesie commented 1 year ago

This commit adds the cacheDir argument to DBDPatternSelect.select since it didn't have it previously but is needed with non-default cache directory locations.

smerckel commented 1 year ago

Thanks for spotting this omission. The alternative would be to make cacheDir an option to the constructor of DBDPatternSelect. In this way, you could use the select() method several times without the need to supply the cacheDir all the time, should you use a non-standard cache directory. Any preference? I am happy to merge your PR, with or without the modification suggested.

hawesie commented 1 year ago

I think your suggestion makes the most sense, since it would be in line with the other classes. I took the current approach to get something working quickly, but I will add to the constructor in the next week or so.

smerckel commented 1 year ago

Thanks for the feedback. Then I propose you undo flagging the pull request as draft, so I can merge your modifications, and then I will move the change to the constructor. Will not take much time anyway.

hawesie commented 1 year ago

Ok, great!

smerckel commented 1 year ago

Fixed as of commit be2cbae95bfe9550a268d83b888735482afa622d

hawesie commented 1 year ago

Awesome, thanks! Does this automatically go to the package available via pip?

smerckel commented 1 year ago

Available via pip as version 0.4.12.