search

smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
90 stars 45 forks source link

Ethcd complementary ions #2274

Closed trishorts closed 11 months ago

trishorts commented 1 year ago

until now, we have not had support for complementary ion searches in MetaMorpheus for the dissociation type EtHcd. This is because there are two ion to add because there are two ion series b/y and c/z. This PR addresses that problem by adding a list of mass shifts rather than a single double.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2274 (d371bb9) into master (dcada1f) will increase coverage by 0.13%. The diff coverage is 53.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2274      +/-   ##
==========================================
+ Coverage   92.01%   92.15%   +0.13%     
==========================================
  Files         135      135              
  Lines       20612    20644      +32     
  Branches     2831     2841      +10     
==========================================
+ Hits        18967    19025      +58     
+ Misses       1161     1134      -27     
- Partials      484      485       +1
Files Changed Coverage Δ
...eus/EngineLayer/ModernSearch/ModernSearchEngine.cs 74.28% <34.54%> (+1.36%) :arrow_up:
...cificEnzymeSearch/NonSpecificEnzymeSearchEngine.cs 86.55% <55.81%> (+4.92%) :arrow_up:
MetaMorpheus/EngineLayer/MetaMorpheusEngine.cs 87.97% <100.00%> (+0.33%) :arrow_up: