smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
91 stars 46 forks source link

Net eight #2391

Closed trishorts closed 3 months ago

trishorts commented 4 months ago

Update MM to .Net 8.0 with accompanying changes to nuget packages and wix. Changes to all .csproj files Added Nunit legacy to avoid annoying changes that accompany Nunit updates.

The following were updated: MathNet.Numerics.MKL.Win" Version="3.0.0" Microsoft.ML" Version="3.0.1" Microsoft.ML.CpuMath" Version="3.0.1" Microsoft.ML.FastTree" Version="3.0.1" Newtonsoft.Json" Version="13.0.3" SharpLearning.CrossValidation" Version="0.31.8" SharpLearning.GradientBoost" Version="0.31.8" SharpLearning.Metrics" Version="0.31.8" System.CodeDom" Version="8.0.0" System.Collections.Immutable" Version="8.0.0" System.Drawing.Common" Version="8.0.7" System.Memory" Version="4.5.5" System.Runtime.CompilerServices.Unsafe" Version="6.0.0" System.Threading.Tasks.Dataflow" Version="8.0.1"

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.62%. Comparing base (4e95528) to head (bb008cf).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2391/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2391 +/- ## ======================================= Coverage 93.62% 93.62% ======================================= Files 140 140 Lines 21891 21895 +4 Branches 3012 3005 -7 ======================================= + Hits 20495 20499 +4 Misses 937 937 Partials 459 459 ``` | [Files](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2391?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [...etaMorpheus/GuiFunctions/MetaDraw/MetaDrawLogic.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2391?src=pr&el=tree&filepath=MetaMorpheus%2FGuiFunctions%2FMetaDraw%2FMetaDrawLogic.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0d1aUZ1bmN0aW9ucy9NZXRhRHJhdy9NZXRhRHJhd0xvZ2ljLmNz) | `95.63% <ø> (ø)` | | | [...ctions/MetaDraw/SpectrumMatch/SpectrumMatchPlot.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2391?src=pr&el=tree&filepath=MetaMorpheus%2FGuiFunctions%2FMetaDraw%2FSpectrumMatch%2FSpectrumMatchPlot.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0d1aUZ1bmN0aW9ucy9NZXRhRHJhdy9TcGVjdHJ1bU1hdGNoL1NwZWN0cnVtTWF0Y2hQbG90LmNz) | `95.22% <ø> (ø)` | | | [...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2391?src=pr&el=tree&filepath=MetaMorpheus%2FTaskLayer%2FSearchTask%2FPostSearchAnalysisTask.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9TZWFyY2hUYXNrL1Bvc3RTZWFyY2hBbmFseXNpc1Rhc2suY3M=) | `93.63% <100.00%> (+0.01%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2391/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)
Alexander-Sol commented 4 months ago

image This error gets thrown at the very end of tasks

trishorts commented 4 months ago

image This error gets thrown at the very end of tasks

You might have an empty net6.0 folder in gui/bin/debug that is acting as bait. happens when you switch between versions. maybe you could look and delete and retry? image

elaboy commented 3 months ago

can you target both net 6.0 and net 8.0?