smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
91 stars 46 forks source link

Deconvolution GUI Modularity #2429

Open nbollis opened 1 month ago

nbollis commented 1 month ago

Refactored the deconvolution parameters handling in the MetaMorpheus GUI to use custom controls and view models for better modularity and extensibility.

To Consider: Do we want to expose the product deconvolution parameters? Do we want to add decon parameter setting to calibration?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.82609% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.73%. Comparing base (97d1761) to head (9a3b9db).

Files with missing lines Patch % Lines
...ons/ViewModels/Deconvolution/DeconHostViewModel.cs 97.05% 1 Missing and 1 partial :warning:
...s/ViewModels/Deconvolution/DeconParamsViewModel.cs 97.75% 1 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2429/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2429 +/- ## ========================================== + Coverage 93.69% 93.73% +0.03% ========================================== Files 141 145 +4 Lines 21883 22067 +184 Branches 3001 3043 +42 ========================================== + Hits 20504 20684 +180 - Misses 927 929 +2 - Partials 452 454 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2429?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [MetaMorpheus/GuiFunctions/MzLibExtensions.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2429?src=pr&el=tree&filepath=MetaMorpheus%2FGuiFunctions%2FMzLibExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0d1aUZ1bmN0aW9ucy9NekxpYkV4dGVuc2lvbnMuY3M=) | `100.00% <100.00%> (ø)` | | | [...odels/Deconvolution/ClassicDeconParamsViewModel.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2429?src=pr&el=tree&filepath=MetaMorpheus%2FGuiFunctions%2FViewModels%2FDeconvolution%2FClassicDeconParamsViewModel.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0d1aUZ1bmN0aW9ucy9WaWV3TW9kZWxzL0RlY29udm9sdXRpb24vQ2xhc3NpY0RlY29uUGFyYW1zVmlld01vZGVsLmNz) | `100.00% <100.00%> (ø)` | | | [...ons/ViewModels/Deconvolution/DeconHostViewModel.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2429?src=pr&el=tree&filepath=MetaMorpheus%2FGuiFunctions%2FViewModels%2FDeconvolution%2FDeconHostViewModel.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0d1aUZ1bmN0aW9ucy9WaWV3TW9kZWxzL0RlY29udm9sdXRpb24vRGVjb25Ib3N0Vmlld01vZGVsLmNz) | `97.05% <97.05%> (ø)` | | | [...s/ViewModels/Deconvolution/DeconParamsViewModel.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2429?src=pr&el=tree&filepath=MetaMorpheus%2FGuiFunctions%2FViewModels%2FDeconvolution%2FDeconParamsViewModel.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0d1aUZ1bmN0aW9ucy9WaWV3TW9kZWxzL0RlY29udm9sdXRpb24vRGVjb25QYXJhbXNWaWV3TW9kZWwuY3M=) | `97.75% <97.75%> (ø)` | |
Alexander-Sol commented 1 month ago

"Minimum intensity ratio" and "Nominal window width" won't accept non-integer inputs.

Alexander-Sol commented 1 month ago

Also, can't set assumed charge states to negative when no data is loaded in.

nbollis commented 1 month ago

Also, can't set assumed charge states to negative when no data is loaded in.

It is set to positive mode. No negatives can be input. Once RNA is added, then the toggle between positive and negative will be exposed.