[EN] Finding the alternate solution of sign-in with google.

smlab-niser / tirtha-public

Project Tirtha

GNU Affero General Public License v3.0

9 stars 7 forks source link

[EN] Finding the alternate solution of sign-in with google. #41

Closed RudrasSingh closed 6 months ago

RudrasSingh commented 8 months ago

Description

-The task was to look for some other options instead of the Sign in with Google which come from google as a button directly including a lot of tracking, So the potential option Authlib with Google is used in solving the problem by completely removing the Google's initial button. [issue 34] (https://github.com/smlab-niser/tirtha-public/issues/34).

Changes Made

Created a new google authentication flow using authlib with django and made the changes in the views.py.
Created a button in index.html file including its CSS in style.css.
Removed the function in the .js file which was handling the sign in workflow previously.

Related Changes

Included a user profile image in the button once the user signs in.

Checklist

[x] Code follows the style guidelines of the project.
[x] All tests pass locally.
[x] Documentation is updated

RudrasSingh commented 7 months ago

@JeS24 Made the PR, please check the relevant files and also ignore the initial commit made, rest 7 commits are valid.

JeS24 commented 7 months ago

We can try rebasing too. First, make the additional changes.

RudrasSingh commented 7 months ago

All the changes are made. Have not pushed the changes yet, waiting for further instructions.

JeS24 commented 7 months ago

@RudrasSingh Commit it here. Let me review the changes completely and then, we can recreate the PR or try rebasing.

RudrasSingh commented 6 months ago

@JeS24 You may check the PR, the said changes have been made.

JeS24 commented 6 months ago

@RudrasSingh There are a lot of extra newlines. Can you run tox -e reformat twice or pre-commit run --all-files once and commit again? Activate the venv and run in terminal inside project root directory (tirtha-public).

JeS24 commented 6 months ago

@RudrasSingh There are a lot of extra newlines. Can you run tox -e reformat twice or pre-commit run --all-files once and commit again? Activate the venv and run in terminal inside project root directory (tirtha-public).

Run this after making the remaining changes.

JeS24 commented 6 months ago

Also, we will create a new PR with only the relevant changes.

JeS24 commented 6 months ago

Closing this in favour of #44,