smnbbrv / ngx-plyr

Angular 6+ binding for Plyr video & audio player
https://smnbbrv.github.io/ngx-plyr/
MIT License
100 stars 65 forks source link

IE11 issues #41

Closed bradrice closed 4 years ago

bradrice commented 4 years ago

Is there a way to get this to work with IE11 and Angular 9? I notice the demo page doesn't work in IE11 so I'm assuming you haven't worried about getting it working in a legacy Internet Explorer?

smnbbrv commented 4 years ago

Hi @bradrice

Normally it is enough to enable ie-related polyfills in the angular app.

So far the lib does not directly use any CSS nor non-angular code I assumed it would just work in ie as is when the related polyfills get enabled. However this is decision of the app developer, not the lib.

If you want to test it with ie just clone the repo locally and enable missing polyfills in src/polyfills.ts

bradrice commented 4 years ago

The issue I get is in IE11:

Object doesn't support property or method 'find' scripts.js (552,5)

which when I run the debugger is plyr.js

smnbbrv commented 4 years ago

that means that looks like you would need a polyfill for Array.prototype.find...