search

smnorris / bcfishpass

Model and monitor aquatic habitat connectivity in BC. Tools to plan and prioritize the assessment and remediation of barriers.
https://smnorris.github.io/bcfishpass
Apache License 2.0
8 stars 13 forks source link

Bulkley Habitat Updates #507

Closed LauraB-CWF closed 5 months ago

smnorris commented 5 months ago

Looks like something is off in the csv formatting. Let me know if you'd like me to take a closer look, the diff is so big it doesn't render in github.

LauraB-CWF commented 5 months ago

Hi Simon,

Yes, I would appreciate that.

Should I send you the changes I am trying to commit?

Thank you,

Laura Bernardi GIS Technician @.*** 350, promenade Michael Cowpland Drive, Kanata, ON K2M 2W1 1.877.599.5777 | 613.599.9594 CanadianWildlifeFederation.cahttp://www.canadianwildlifefederation.ca/?src=signature | Federationcanadiennedelafaune.cahttp://www.federationcanadiennedelafaune.ca/?src=signature

[seeds]http://donate.cwf-fcf.org/site/Donation2?df_id=7440&mfc_pref=T&7440.donation=form1&utm_source=signature&utm_medium=referral&utm_campaign=biod

Let's celebrate Canada's biodiversity by planting pollinator-friendly seeds. Request your free seeds >http://donate.cwf-fcf.org/site/Donation2?df_id=7440&mfc_pref=T&7440.donation=form1?utm_source=signature&utm_medium=email&utm_campaign=mmg

Célébrons la biodiversité du Canada en plantant des semences favorables aux pollinisateurs. Demandez vos semences gratuites >http://donate.cwf-fcf.org/site/Donation2?df_id=7440&mfc_pref=T&7440.donation=form1?utm_source=signature&utm_medium=referral&utm_campaign=biod&s_locale=fr_CA

From: Simon Norris @.> Sent: Tuesday, June 4, 2024 3:14 PM To: smnorris/bcfishpass @.> Cc: Laura Bernardi @.>; Author @.> Subject: Re: [smnorris/bcfishpass] Bulkley Habitat Updates (PR #507)

CAUTION: EXTERNAL EMAIL / ATTENTION: COURRIEL EXTERNE

Looks like something is off in the csv formatting. Let me know if you'd like me to take a closer look, the diff is so big it doesn't render in github.

- Reply to this email directly, view it on GitHubhttps://github.com/smnorris/bcfishpass/pull/507#issuecomment-2148226177, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCMSYWAPLCPNPE5VXAEZX3DZFYGXHAVCNFSM6AAAAABIZCOC5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGIZDMMJXG4. You are receiving this because you authored the thread.Message ID: @.**@.>>

smnorris commented 5 months ago

No, I can grab the PR - thanks!

On Jun 4, 2024, at 12:20 PM, LauraB-CWF @.***> wrote:

Hi Simon,

Yes, I would appreciate that.

Should I send you the changes I am trying to commit?

Thank you,

Laura Bernardi GIS Technician @.*** 350, promenade Michael Cowpland Drive, Kanata, ON K2M 2W1 1.877.599.5777 | 613.599.9594 CanadianWildlifeFederation.cahttp://www.canadianwildlifefederation.ca/?src=signature | Federationcanadiennedelafaune.cahttp://www.federationcanadiennedelafaune.ca/?src=signature

[seeds]http://donate.cwf-fcf.org/site/Donation2?df_id=7440&mfc_pref=T&7440.donation=form1&utm_source=signature&utm_medium=referral&utm_campaign=biod

Let's celebrate Canada's biodiversity by planting pollinator-friendly seeds. Request your free seeds >http://donate.cwf-fcf.org/site/Donation2?df_id=7440&mfc_pref=T&7440.donation=form1?utm_source=signature&utm_medium=email&utm_campaign=mmg

Célébrons la biodiversité du Canada en plantant des semences favorables aux pollinisateurs. Demandez vos semences gratuites >http://donate.cwf-fcf.org/site/Donation2?df_id=7440&mfc_pref=T&7440.donation=form1?utm_source=signature&utm_medium=referral&utm_campaign=biod&s_locale=fr_CA

From: Simon Norris @.> Sent: Tuesday, June 4, 2024 3:14 PM To: smnorris/bcfishpass @.> Cc: Laura Bernardi @.>; Author @.> Subject: Re: [smnorris/bcfishpass] Bulkley Habitat Updates (PR #507)

CAUTION: EXTERNAL EMAIL / ATTENTION: COURRIEL EXTERNE

Looks like something is off in the csv formatting. Let me know if you'd like me to take a closer look, the diff is so big it doesn't render in github.

smnorris commented 5 months ago

It looks like the change is new trailing commas on each line - basically a new empty column. Remove that column/trailing commas and all should be good.

smnorris commented 5 months ago

closing - covered by #509