search

smogon / damage-calc

Pokemon games damage calculator
https://calc.pokemonshowdown.com
MIT License
397 stars 367 forks source link

Implement Ability Shield #520

Closed Zrp200 closed 1 year ago

Zrp200 commented 1 year ago

Under this implementation, if the ability is a Mold Breaker ability, it will still be shown even as it is ignored, and the Ability Shield will also be shown.

AustinXII commented 1 year ago

I think the problem with showing abilities that are being ignored will be users thinking there’s a bug with the calc

urkerab commented 1 year ago

(Out of interest I checked current behaviour which is that if you use Mold Breaker against Multiscale then Multiscale isn't shown but if you use it against Shadow Shield then Mold Breaker isn't shown.)

Zrp200 commented 1 year ago

The way I see it, it might be confusing for the ability to arbitrarily not show up, given Ability Shield is an item and not an ability. All these ability interactions can prove quite confusing if not shown ("why is Turboblaze not ignoring Flash Fire? isn't this a bug?") I'm of the opinion more information is better than less information, as the answer can simply be "Ability Shield". Part of the interaction, after all, is the interaction of the abilities.

However, it is true that it does make calculations longer while still giving the same effect in the end. If you'd like me to omit the interaction, I'll change the code; it's a one line fix.

AustinXII commented 1 year ago

sure we can try this