search

smogon / damage-calc

Pokemon games damage calculator
https://calc.pokemonshowdown.com
MIT License
397 stars 367 forks source link

Implement Big Root Interactions with Draining Moves #524

Closed Zrp200 closed 1 year ago

Zrp200 commented 1 year ago

This should resolve #516.

I added a test for the draining interactions near the other draining interaction tests. I did not add a test for the leech seed interaction, though, since I wasn't sure where it would go.

AustinXII commented 1 year ago

Doesn’t big root also need some work done in the mechanics files ?

Zrp200 commented 1 year ago

Doesn’t big root also need some work done in the mechanics files ?

I don't see where the changes would be made. Big Root multiplies the recovery from Leech Seed and draining moves by 1.3 after the recovery amount is calculated. It doesn't affect the actual damage of any moves.

AustinXII commented 1 year ago

Ah I thought it also increased damage of draining moves

AustinXII commented 1 year ago

Thanks!