smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.67k stars 2.72k forks source link

amulet coin isn't in items #6989

Open EvGym opened 4 years ago

EvGym commented 4 years ago

we have every Pokeball (as far as I checked) and bottle caps, but no amulet coin?

Zarel commented 4 years ago

I'm not opposed to Amulet Coin, but we usually draw the line at items with no competitive relevance.

(Balls and bottle caps don't have relevance as held items, but they're used competitively in other ways which makes them convenient to include.)

EvGym commented 4 years ago

would you happen to know how to add the image of the item? I would love to be able to do it myself on my own fork of the repository.

Zarel commented 4 years ago

Images are unfortunately not open-source, and so can't be easily changed with a pull request or anything like that.

EvGym commented 4 years ago

well drat. Thank you anyway.

Zarel commented 4 years ago

I believe @monsanto and @Marty-D were most recently working on sprites and would know how to add an item sprite.

Marty-D commented 4 years ago

Every item that existed in Gen 5, no matter how irrelevant, is already in the sprite sheet: https://play.pokemonshowdown.com/sprites/itemicons-sheet.png You just have to point at it with spritenum.

EvGym commented 4 years ago

Thank you!

EvGym commented 4 years ago

So, I tried adding the item and it seems that the code ignores the sprite number I give it. I even tried making another item look like it and it changed nothing. Is this set up in another location other than data -> items?

Zarel commented 4 years ago

It requires both server and client changes (server changes should be in client/data/pokemon-showdown), and build full. Are you doing both?

EvGym commented 4 years ago

build full?

Zarel commented 4 years ago

By default, the testclient will take data files from play.pokemonshowdown.com. If you do a build full in place of build, you will instead build and use your own copy of the data files from a clone of the server repository in data/Pokemon-Showdown/.

EvGym commented 4 years ago

Oh! Alright, thank you

EvGym commented 4 years ago

How do you do a full build? I have been trying for awhile and have no idea how to do it. I have been trying commands like "npm run-script build full" but nothing seems to happen.

AnnikaCodes commented 4 years ago

How do you do a full build?

Use the command node build full.

EvGym commented 4 years ago

Alright, it didn't work. I edited data -> items and added the item. Any idea what could be keeping it from working? I even tried changing an existing item's sprite number.

That seems to be the only location that stores items unless there is another repository I need to use?

(unrelated question, can I and how do I register my own showdown server so it can save replays?)

Edit: let me clerify. No listed or unlisted use of the build full command i have found allows the item to show up.