fix: patch fs-extra to fix images on arm64

[jnsgruk]

Fixes #279

Adds a patch to the build which reportedly fixes an issue rendering images on arm64.

@CarstenKochElsdorf perhaps you could build & test?

[CarstenKochElsdorf]

Fixes #279

Adds a patch to the build which reportedly fixes an issue rendering images on arm64.

@CarstenKochElsdorf perhaps you could build & test?

I did. sadly, it still does not work.

Here are two screen shots from my snap build (bad) and dennisameling build (good):

[CarstenKochElsdorf]

I have never built a snap before. Maybe I made a mistake?

Here is what I did:

cko@opim:~$ git clone https://github.com/snapcrafters/signal-desktop.git
Cloning into 'signal-desktop'...
remote: Enumerating objects: 1333, done.
remote: Counting objects: 100% (1331/1331), done.
remote: Compressing objects: 100% (661/661), done.
remote: Total 1333 (delta 688), reused 1249 (delta 624), pack-reused 2 (from 1)
Receiving objects: 100% (1333/1333), 346.79 KiB | 4.28 MiB/s, done.
Resolving deltas: 100% (688/688), done.
cko@opim:~$ cd signal-desktop/
cko@opim:~/signal-desktop$ git fetch origin pull/318/head:pr-318
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 6 (delta 3), reused 6 (delta 3), pack-reused 0 (from 0)
Unpacking objects: 100% (6/6), 1.19 KiB | 173.00 KiB/s, done.
From https://github.com/snapcrafters/signal-desktop
 * [new ref]         refs/pull/318/head -> pr-318
cko@opim:~/signal-desktop$ git checkout pr-318
Switched to branch 'pr-318'
cko@opim:~/signal-desktop$ sudo snap install snapcraft --classic
snapcraft 8.4.1 from Canonical✓ installed
cko@opim:~/signal-desktop$ snapcraft
lxd (5.21/stable) 5.21.2-2f4ba6b from Canonical✓ installed
Failed to install LXD: user must be manually added to 'lxd' group before using LXD.                                                                            
Recommended resolution: Visit https://documentation.ubuntu.com/lxd/en/latest/getting_started/ for instructions on installing and configuring LXD for your operating system.                                                                    
Full execution log: '/home/cko/.local/state/snapcraft/log/snapcraft-20240924-233524.864896.log'                                                                
cko@opim:~/signal-desktop$ sudo usermod -aG lxd $USER
cko@opim:~/signal-desktop$ newgrp lxd
cko@opim:~/signal-desktop$ lxd init
Would you like to use LXD clustering? (yes/no) [default=no]: 
Do you want to configure a new storage pool? (yes/no) [default=yes]: 
Name of the new storage pool [default=default]: 
The requested storage pool "default" already exists. Please choose another name.
Name of the new storage pool [default=default]: ^C
cko@opim:~/signal-desktop$ snapcraft
Pulling signal-desktop \ (60.4s)                                        Pulling signal-desktop | (60.5s)                                        PuPacked signal-desktop_7.25.0_arm64.snap                                                                                                          
cko@opim:~/signal-desktop$ sudo snap install --dangerous signal-desktop_*.snap
signal-desktop 7.25.0 installed

[jnsgruk]

Hmm, that looks right. I'll have a poke about and check the patch was applied properly

[jnsgruk]

@CarstenKochElsdorf I just updated this slightly, I don't think the patch was applied properly. Can you try a pull and rebuild?

cd <your clone>
git pull
snapcraft --verbose

sudo snap remove signal-desktop
sudo snap install ./signal-desktop_7.25.0_amd64 --dangerous

[CarstenKochElsdorf]

Working now. Thank you!

[jnsgruk]

Nice, should land in latest/stable some time today.