fix(gadgets): bugs in assign_bit

snarkify / sirius

A Plonkish folding framework for Incrementally Verifiable Computation (IVC).

MIT License

136 stars 19 forks source link

Closed cyphersnake closed 2 months ago

cyphersnake commented 2 months ago

Motivation There was a bug, since:

a was twice assigned into s[0] rather than into s[0] & s[1]
q_o was not assigned at all, but q_m was assigned twice. So the actual check did not take place

Overview Aside from the fix itself, I've refactored a bit to make it more obvious which columns are used within the function

cyphersnake commented 2 months ago

Will merge a little later, because of PR-trait around