There are two issues with getting into the polite pool of CrossRef:
the mailto parameter is currently never set. since get_crossref is basically a private method, the parameter would have to be added to every public method (e.g. journal_search, fetch_paper_page). could be improved by making it an object where the parameter is set once at creation.
the contact parameter for get_crossref has the wrong type (-> Config). If you would hand over your config to the method the mailto parameter would be something like db=PosixPath('db.sqlite') log_dir=PosixPath('logs') host='localhost' port=8000 env='dev' crossref_email=None public_url='http://localhost'
There are two issues with getting into the polite pool of CrossRef:
mailto
parameter is currently never set. sinceget_crossref
is basically a private method, the parameter would have to be added to every public method (e.g.journal_search
,fetch_paper_page
). could be improved by making it an object where the parameter is set once at creation.contact
parameter forget_crossref
has the wrong type (->Config
). If you would hand over your config to the method themailto
parameter would be something likedb=PosixPath('db.sqlite') log_dir=PosixPath('logs') host='localhost' port=8000 env='dev' crossref_email=None public_url='http://localhost'