sni / mod_gearman

Distribute Naemon Host/Service Checks & Eventhandler with Gearman Queues. Host/Servicegroups affinity included.
http://www.mod-gearman.org
GNU General Public License v3.0
122 stars 42 forks source link

Mod_gearman 3.0.1 doesn't parse line returns correctly #112

Closed McRiverside closed 7 years ago

McRiverside commented 7 years ago

Hi,

We have a Nagios XI 5.4.2 alonside with gearmand 0.33 runnning. Every mod_gearman_worker runs the 3.0.1 version.

Mod_gearman doesn't parse multi lines returns in the long_ooutput field as Nagios would normally do, it puts everything into the output field.

Result with mod_gearman: output: ABC\nDEF\nGHI\n long_output: null Expected result: output: ABC Long_output:DEF\nGHI\n

Can anyone tell me where to change it in the NEB to parse it correctly and make use of the long_output field?

Thank you, Alexandre

barry-luijten commented 7 years ago

mod-gearman 3.0.0 and 3.0.3 also seem to have this issue. Newlines are not parsed and are appended as "\n" to the perfdata and plugin_output string... Example:

Status Information: OK - load average: 2.17, 2.02, 1.53
Performance Data:   load1=2.170;25.000;30.000;0; load5=2.020;15.000;20.000;0; load15=1.530;10.000;15.000;0; \n
sni commented 7 years ago

I don't have access to any nagios xi, maybe @hedenface want to have a look

hedenface commented 7 years ago

I'll take a look.

hedenface commented 7 years ago

Fixed in #118 PR.

barry-luijten commented 7 years ago

Thanks Bryan! I hope it will be merged swiftly :)

wleese commented 7 years ago

Currently trying to track down an issue with nagios crashing - could this issue have such an impact? (https://github.com/NagiosEnterprises/nagioscore/issues/391)

sni commented 7 years ago

Merged, thanks.