search

sni / mod_gearman

Distribute Naemon Host/Service Checks & Eventhandler with Gearman Queues. Host/Servicegroups affinity included.
http://www.mod-gearman.org
GNU General Public License v3.0
122 stars 42 forks source link

fix #136 #139

Closed amuhametov closed 5 years ago

amuhametov commented 5 years ago

need someone to verify it works

sni commented 5 years ago

i don't have any nagios 4 setups, but i am willing to merge anything which doesn't break the naemon or icinga neb module :-)

amuhametov commented 5 years ago

@sni do you mind I add neb_module_nagios44 to make it possible to use same mod_gearman package with both nagios 4.3 and 4.4? This requires extra nagios include dir alongside with extra defines an configure options.

sni commented 5 years ago

No, i don't want that. It would be much easier if there would be a nagios4-devel package containing the headers and library. Then you could just use the version you like. Thats the way we do it with naemon.

sawolf commented 5 years ago

I don't think distributing multiple versions of the headers would work here. The issue is that adjust_host_check_attempt() was removed between nagios 4.3.4 and 4.4.0. It does actually still exist in the headers but the definition/calls to it no longer exist. I'll talk to @hedenface about adding back an empty definition for the function but as it stands this works in the most recent version.

hedenface commented 5 years ago

I'd rather not have an empty function definition - but we should definitely remove it from the headers.

Why can't we just remove the calls to the function from mg?

sni commented 5 years ago

If it was removed on purpose, its ok, just wanted to make sure its not a mistake. Just keep it like that then.

amuhametov commented 5 years ago

fix #136 Added nagios 4.4 support May be (sure will be) incompatible with nagios-core <= 4.3

amuhametov commented 5 years ago

So, after 2 weeks I can say it works fine.

@sni will you merge this pr?

sni commented 5 years ago

sure, thanks a lot

amuhametov commented 5 years ago

@Madlohe do you use thruk?

sawolf commented 5 years ago

@amuhametov nope! I'm a developer for Nagios Enterprises (one of @hedenface 's underlings).