Adding dotenv config, unit-testing framework

snift / snift-api

🏗 Backend REST API for Snift to sniff security vulnerabilities from the web.

MIT License

2 stars 0 forks source link

Adding dotenv config, unit-testing framework #6

Closed shrirambalaji closed 5 years ago

shrirambalaji commented 5 years ago

@maruthi-adithya Review the changes and lmk. Mostly only moving around things / cosmetic changes/ naming and minor refactoring based on stuff I see in other popular repos.

Added a single unit test as of now, WIP: adding unit tests for others.

Also added a dotenv module, that pulls in a file called .env, which will be a central place to store any deployment or application config (gitignored)

maruthi-adithya commented 5 years ago

@Shriram-Balaji Can you add a check for the Input String. If it is not valid, return 400. Also, if there is any procedure to write tests, add to the documentation.

shrirambalaji commented 5 years ago

@maruthi-adithya added http error handling, removed utils.splitHostPort and used inbuilt method instead. lmk after review. Also note, codacy PR Review we have doesnt seem to be configured to review changes develop branch, make sure that's done as well to avoid showing MR check errors.

All my MRs will be to develop and not to master.