Driver test to read parameters file

snowflakedb / gosnowflake

Go Snowflake Driver

Apache License 2.0

302 stars 125 forks source link

Driver test to read parameters file #1245

Closed rickr-sigma closed 1 week ago

rickr-sigma commented 1 week ago

Description

The README states to use a parameters.json file for the test connection configuration. This works fine when running make test, but if you want to run a test in an ide or individual ones this file is ignored and you need to manually set the env vars.

Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

github-actions[bot] commented 1 week ago

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

sfc-gh-pfus commented 1 week ago

Hi @rickr-sigma ! Thanks for expressing your interest in that area. Unfortunately, we don't want to change it. Readme states that this file is used for make test and it is fine. It is the same way as it works in all our drivers. Sorry for the inconvenience that it makes for you!