snowflakedb / snowflake-connector-python

Snowflake Connector for Python
https://pypi.python.org/pypi/snowflake-connector-python/
Apache License 2.0
601 stars 473 forks source link

Infer TLD for China based on region in account #2040

Closed sfc-gh-vvenugopal closed 3 months ago

sfc-gh-vvenugopal commented 3 months ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

github-actions[bot] commented 3 months ago


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

sfc-gh-aling commented 3 months ago

LGTM, thanks for the PR. could you help update the changelog https://github.com/snowflakedb/snowflake-connector-python/blob/main/DESCRIPTION.md

and sign the CLA as per the instruction in bot's comment: https://github.com/snowflakedb/snowflake-connector-python/pull/2040#issuecomment-2318569033

sfc-gh-vvenugopal commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

sfc-gh-vvenugopal commented 3 months ago

recheck