Caching improvements - Githubissues

snowplow / iglu-scala-client

Scala client for Iglu schema registry

https://github.com/snowplow/iglu/wiki

Apache License 2.0

5 stars 13 forks source link

Caching improvements #203

Closed istreeter closed 2 years ago

istreeter commented 2 years ago

TODOs

[x] Consider removing ValidatorF as a trait, and instead directly call methods from CirceValidator
[x] Revisit checkSchemaF -- does it need to call V4Schema.validate(json) ?
[x] Use ResolverResult for listSchemas - to enable caching improvements in RDB transformer (since 1.2.0-M4)
[x] Write lots of tests
[ ] Port everything to the CE3 branch (master, 2.1.0 version) - this was started here (compiles, not checked further)

snowplowcla commented 2 years ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

istreeter commented 2 years ago

Thanks @pondzix! I implemented some suggested changes and opened a task list for the other good ideas which I've not had time for yet.

pondzix commented 2 years ago

Changes for branch 1.x released in https://github.com/snowplow/iglu-scala-client/pull/208 with version 1.2.0 Changes for branch 2.x on https://github.com/snowplow/iglu-scala-client/tree/enhancement/cache-validation-by-ttl-improved-ce3