search

snowplow / iglu

Iglu is a machine-readable, open-source schema repository for JSON Schema from the team at Snowplow
http://www.snowplow.io
Apache License 2.0
206 stars 44 forks source link

ScalaCheck Schema DDL: add #392

Closed chuwy closed 6 years ago

chuwy commented 6 years ago

scalacheck-schema-ddl is a module responsible for generating self-describing JSON instances out of JSON Schemas. It has schema-ddl in name because it leverages typesafe JSON Schema AST from Schema DDL project.

/cc @BenFradet @asoltysik

BenFradet commented 6 years ago

I think it'd make sense to externalize it to a different repo as it can be useful to people not using iglu at all, I created https://github.com/snowplow-incubator/json-schema-gen as a placeholder (we can definitely find a better name)

chuwy commented 6 years ago

I have few counter-arguments (though I definitely prefer multi-repos):

  1. It will depend on Schema DDL through JSON Schema AST and therefore several other Iglu libs (Scala Core at least)
  2. I was planning to add Iglu Client shortcuts to generate schemas out of remote registries
alexanderdean commented 6 years ago

I say keep it here for speed of development. It can always be moved out (orchid pattern) later if it's useful.

BenFradet commented 6 years ago

It will depend on Schema DDL through JSON Schema AST and therefore several other Iglu libs (Scala Core at least)

why does this make having it in this repo mandatory?

I was planning to add Iglu Client shortcuts to generate schemas out of remote registries

same as above. Additionally this seems a bit out of the original scope to me. It'd better fit as a submodule, wdyt?

I'd argue that incorporating it to this repo will completely prevent wide-spread usage (SEO will be awful).

alexanderdean commented 6 years ago

I'd argue that incorporating it to this repo will completely prevent wide-spread usage (SEO will be awful).

That's not in any way our priority though. Our priority is launching a BigQuery Loader for GCP - whatever is faster to that end.

chuwy commented 6 years ago

why does this make having it in this repo mandatory?

Not mandatory at all. It was the point regarding people not using Iglu - there will be huge part of Iglu anyway. As of actual repo - ok, I'm moving it to same https://github.com/snowplow-incubator/json-schema-gen, I think it will be faster to keep it out of main repo.

chuwy commented 6 years ago

...or actually https://github.com/snowplow-incubator/scalacheck-schema

alexanderdean commented 6 years ago

scalacheck-schema

Nice name