search

snowplow / iglu

Iglu is a machine-readable, open-source schema repository for JSON Schema from the team at Snowplow
http://www.snowplow.io
Apache License 2.0
208 stars 45 forks source link

Scala Core: swap SelfDescribingData member names #394

Closed knservis closed 5 years ago

knservis commented 6 years ago

https://github.com/snowplow/iglu/blob/8d333417a8e03ad1b9bf11d61211dd3fbd4ab17d/0-common/scala-core/src/main/scala/com.snowplowanalytics.iglu/core/SelfDescribingData.scala#L22

miike commented 6 years ago

@chuwy What values does this refer to swapping? SelfDescribingData => ?

chuwy commented 6 years ago

@miike in docstring we have

  * @param data reference to Schema
  * @param schema attached data instance itself

While it should be:

  * @param schema reference to Schema
  * @param data attached data instance itself
miike commented 6 years ago

Simple - I've added a PR for the change.