search

snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
152 stars 61 forks source link

Fix #199: support GHC 9.2 (base 4.16) by putting Option under #if #201

Closed andreasabel closed 2 years ago

andreasabel commented 2 years ago

Fix #199: support GHC 9.2 (base 4.16) by putting Option under #if

In base-4.16, Option was removed.

Bump version to 1.0.15.3.

I tested manually that this PR compiles with GHC 8.8 - 9.2.1-rc1.

andreasabel commented 2 years ago

Looks like I reinvented the wheel, this solution was already found by @RyanGlScott at https://gitlab.haskell.org/ghc/head.hackage/-/blob/master/patches/mono-traversable-1.0.15.1.patch.

parsonsmatt commented 1 year ago

any chance we could get a Hackage release on this?

snoyberg commented 1 year ago

I think this change is already on Hackage, mega-sdist shows that the code in the repo matches what's on Hackage.

parsonsmatt commented 1 year ago

Oh, very weird. We're depending on this commit for mutable-containers, which was last uploaded in 2018. I wonder what we're actually depending on? 🤔