search

snozbot / fungus

An easy to use Unity 3D library for creating illustrated Interactive Fiction games and more.
MIT License
1.59k stars 291 forks source link

Comma as a separation character messes with some localized float representation. #1050

Open loothunter1 opened 2 years ago

loothunter1 commented 2 years ago

On some localized systems (e.g. mine) floats have comma(,) separating integer part from the fraction part instead of dot(.). Because of that separating parameters in GetSettingsString/SetSettingsString in SfxrParams.cs with comma(,) creates a string that isn't read correctly. Please, change that symbol to something else.

I hope, my explanation was adequate, I have limited programming knowledge and English isn't my first language.

Thank you.

stevehalliwell commented 2 years ago

Sounds like something needs to be using InvariantCulture that isn't. If that is a string being manually editted by the user they need to be entered as InvariantCulture.