snyk / gradle-plugin

Snyk Gradle Plugin - Scanning and monitoring your dependencies for security vulnerabilities from Gradle
Other
20 stars 19 forks source link

Re-implement plugin using Kotlin and Gradle incremental build APIs #17

Closed adam-dpg closed 1 month ago

adam-dpg commented 2 years ago

Work in progress!

You can already use this release - see the README here

Depends on https://github.com/snyk/gradle-plugin/pull/16

Resolves https://github.com/snyk/gradle-plugin/issues/4 Resolves https://github.com/snyk/gradle-plugin/issues/5 Resolves https://github.com/snyk/gradle-plugin/issues/6 Resolves https://github.com/snyk/gradle-plugin/issues/7 Resolves https://github.com/snyk/gradle-plugin/issues/8 Resolves https://github.com/snyk/gradle-plugin/issues/11 Resolves https://github.com/snyk/gradle-plugin/issues/13 Resolves https://github.com/snyk/gradle-plugin/issues/14

TODO

svenXY commented 5 months ago

Hi, I have a problem with the plugin which is described there: https://discuss.gradle.org/t/kotlin-task-in-8-8-suddenly-fails-due-to-wrong-directory/48618.

The plugin assumes that ...

the Project directory is the current user working directory. This was never guaranteed and also is not always the case even before 8.8.

It often is the case, but it can be the daemon directory, it can be the IDE installation directory, …

There is no guarantee what the current user working directory is, and any Gradle plugin that assumes this has a bug that just waits for blowing off."

And this is indeed the case with gradle 8.8 - after starting the daemon, the working directory is not the build directory, but $GRADLE_HOME/daemon/8.8 and there the snyk plugin of course cannot find any files to analyse.

According to a comment from a seasoned gradle user, your MR seems to fix it: https://discuss.gradle.org/t/kotlin-task-in-8-8-suddenly-fails-due-to-wrong-directory/48618/3?u=svenxy .

Any chance you bring this up again and have it merged?

Otherwise we would have to stop using it in our CI pipeline and migrate to a commandline-only version

bmvermeer commented 1 month ago

closing since this is a draft since 2022