search

socketio / socket.io-client-swift

Other
5.21k stars 839 forks source link

Bump minimum deployment target to iOS 12 to match Starscream dependency #1482

Closed elefantel closed 5 months ago

elefantel commented 5 months ago

Currently there is an error when compiling for release:

Compiling for iOS 11.0, but module 'Starscream' has a minimum deployment target of iOS 12.0

This pull request addresses this error by bumping the minimum deployment target to match Starscream.

shuftipro commented 5 months ago

Facing same issue.

shuftipro commented 5 months ago

@nuclearace Could you kindly provide an update on when you plan to merge changes into the master branch? We're currently unable to proceed with the new version due to this conflict.

elefantel commented 5 months ago

Just following up as well to get an ETA on this @nuclearace?

ghorbani-m commented 5 months ago

@nuclearace I got the same issue when trying to push my iOS module to Cocoapods, Could you please let me know when you will merge this fix to the master branch?

elefantel commented 4 months ago

It is apparent this will not be attended to anytime soon. Anyone still having this issue I managed to fix it by fixing the Startscream version on the podspec to the last known working version 4.0.6. Then Socket IO uses that version you specify instead of the latest version 4.0.8.

s.dependency 'Starscream', '4.0.6'
s.dependency 'Socket.IO-Client-Swift', '~> 16.1.0'