socotecio / django-socio-grpc-example

Simple examples of how to use DSG
Apache License 2.0
2 stars 2 forks source link

Feature/async example bibliography #3

Closed markdoerr closed 12 months ago

markdoerr commented 1 year ago

@AMontagu and @legau,

I am currently finalizing our first example.

Here are the TODOs I have in mind:

Anything else, I forgot ? Please let me know, how you like the example ? Could we use it in the ReadTheDocs Documentation, to explain the concepts better (with references to this repo ?) I think it would make things a lot clearer.

AMontagu commented 1 year ago

Hello @markdoerr Some feedback before reading everything:

You have both read/write or async for/ yied method that can be used for serveur and client both depending of need. Note that await stream_caller.done_writing() is only needed in test as server and client automatically close connection but test does not

markdoerr commented 1 year ago

Hello @AMontagu,

  • Why the name bib mean ?

In some cases I abbreviated "Bibliography" by "bib" - I hope, only in long filenames or variable names.

  • As we recommend only async app as example can we remove the async world in it ?

I agree :)

  • SearchFilters is supported

Cool - then I prepare an example

Thanks for the link, the hopefully simplifies life.

You have both read/write or async for/ yied method that can be used for serveur and client both depending of need. Note that await stream_caller.done_writing() is only needed in test as server and client automatically close connection but test does not

Thanks for the hint - I will keep it in mind :)

  • Full async client: there was an example in the repo of an async client. How can I help ? (see backend/client.py file that is removed)

I kept the code in one example as a comment - to adopt it to the new model. I would be happy, if you could test it, when I am done (and provide me some feedback) - I will ping you again, thanks for

  • Okay to continue with jupyter notebook

8)

  • No need for unit test in example I think

we move this point then to version 2.0 ;)

markdoerr commented 1 year ago

Hi @AMontagu and @legau, I am almost complete with the example now (and I am glad, that everything is running ;). I will just add some filter/search examples tonight, but please feel free to have a look at the current state and add some suggestions, what we forgot to demonstrate of your framework (I think, there are still quite some features missing, but we have a basis now for extension).

AMontagu commented 12 months ago

This start to be a too big PR and almost all is good. I merge it and we can open issue or other MR for improvement

markdoerr commented 12 months ago

:+1: - it simplifies things, @AMontagu ... I will work on some of the points both of you raised in the next days...