sodafoundation / nbp

NorthBoundPlugins for platforms and clients to connect to SODA Data Framework
Apache License 2.0
51 stars 39 forks source link

[CSI] Profile name should be supported in place of profile id in storage class #334

Open sushanthakumar opened 4 years ago

sushanthakumar commented 4 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened: At present, CSI takes profile info through profile id. Profile id can change and also not convenient for user to use. So profile name is more useful and convenient to use while creating K8S storage class

image

What you expected to happen: CSI plugin should support accepting profile name instead of profile id

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

sushanthakumar commented 4 years ago

Not addressing for Faroe release

asifdxtreme commented 3 years ago

@sushanthakumar @kumarashit As per Isabela relase, the Dashboard allows changes to the name of soda-profile, so in this case it will be contradictory. So I guess the ID is constant and the name can change, so IMO let's better stick to profile ID OR else we disable the edit option for soda-profile name and then make the name as the parameter in storage class.