search

sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
934 stars 312 forks source link

MeshObjLoader how to handle handleSeams option generically #1100

Open epernod opened 5 years ago

epernod commented 5 years ago

There is a conflict using MeshObjLoader for mechanical and for rendering purpose.

for OglModel MeshObjLoader should have handleSeams = 1 to have multiple vertices at a same position and better handle texture seams and normals.

But this option should not be used for Topology (if I well understood). Several tests are breaking in PR #1096 where handleSeams has been set to true by default.

Suggested labels:

fredroy commented 5 years ago

If the VisualModel(Impl) is the only one making use of handleSeams option, I would say it means that the duplicating vertices mechanism should be present in the VisualModel(Impl), and not in the MeshObjLoader. (and it would allow this duplicating thing to be handled by other file format actually)

hugtalbot commented 4 years ago

this seems still a feasible task for the coding spring STC#10