search

sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
934 stars 312 forks source link

UserInterface: Unifying the way to specify colors in the scene #64

Closed damienmarchal closed 7 years ago

damienmarchal commented 8 years ago

In sofa, some component allows to specify colors by writing color="1,0,0" and "red" while others just allow color="1,0,0".

This is a consistency issue (very very bad for the user experience). So we should unify this in all sofa for the next release.

DM.

damienmarchal commented 8 years ago

Actually we also have the same problem for 'ambient' and other color related data fied.

There is also inconsistencies in 'filename' that can be either of String or DataFilename type.

guparan commented 8 years ago

TODOs have been added by pull request #65

guparan commented 7 years ago

@damienmarchal could you set priority and difficulty tags for this task? Thanks :)

damienmarchal commented 7 years ago

@guparan It is relatively easy because there is already good examples in some Sofa components. So it is more a factor of refactoring/reorganize/reuse existing code.

I consider that anything that has consequence on the User Experience is of high priority (in order to get more and more happy sofa users). Data fields are a big part of the sofa User Interface.

damienmarchal commented 7 years ago

Hi all

I started implementing something for this but I'm facing a weird compilation issue on VS2015 for which I have no idea on how to solve it https://github.com/sofa-framework/sofa/pull/119

If you have an idea, please share.

damienmarchal commented 7 years ago

This PR solve the issue https://github.com/sofa-framework/sofa/issues/124 So when merged... we can close that.