sofa-framework / sofa

Real-time multi-physics simulation with an emphasis on medical simulation.
https://www.sofa-framework.org
GNU Lesser General Public License v2.1
934 stars 312 forks source link

check which component is using : handleTopologyChange() function or TopologicalData #810

Open hugtalbot opened 6 years ago

hugtalbot commented 6 years ago

Help on the Topology work, in finding the work affected by handleTopologicalChange()

Forcefields handling topology change:

Forcefields not handling:

List of components with handleTopologyChange method

  1. void BarycentricMapping<TIn, TOut>::handleTopologyChange ( core::topology::Topology* t )
  2. void BarycentricMapperHexahedronSetTopology<In,Out>::handleTopologyChange(core::topology::Topology* t)
  3. void IdentityMapping<TIn, TOut>::handleTopologyChange()
  4. void UniformMass<DataTypes, MassType>::handleTopologyChange() PR #2377
  5. void VisualModelImpl::handleTopologyChange() PR #2300
  6. void SpringForceField::handleTopologyChange(core::topology::Topology *topo)
  7. void TLineModel::handleTopologyChange()
  8. void PointLocalMinDistanceFilter::handleTopologyChange() Component removed
  9. void TriangleLocalMinDistanceFilter::handleTopologyChange() Component removed
  10. void TTriangleModel::handleTopologyChange() PR #903
  11. inline void HexahedronFEMForceField::handleTopologyChange()
  12. inline void TetrahedronFEMForceField::handleTopologyChange()
  13. OglTetrahedralModel< gpu::cuda::CudaVectorTypes<TCoord,TDeriv,TReal> > Component removed
  14. CudaVisualModel
  15. TetrahedronModel::handleTopologyChange() PR #1354
  16. void PositionBasedDynamicsConstraint::handleTopologyChange()
  17. void UncoupledConstraintCorrection< DataTypes >::handleTopologyChange() PR #1115
  18. void BarycentricMapperHexahedronSetTopology<defaulttype::Vec3Types, defaulttype::Rigid3Types>::handleTopologyChange(core::topology::Topology* t)
  19. void DeformableOnRigidFrameMapping<TIn, TInRoot, TOut>::handleTopologyChange(core::topology::Topology* t)
  20. void ExternalInterpolationMapping<TIn, TOut>::handleTopologyChange(core::topology::Topology /t*/)
  21. void NonUniformHexahedralFEMForceFieldAndMass::handleTopologyChange(core::topology::Topology* t)
  22. void OglAttribute< size, type, DataTypes>::handleTopologyChange() PR #1159
  23. void OglShaderVisualModel::handleTopologyChange()

Suggested labels:

agpetit commented 6 years ago

apparently handleTopologicalChange() is not used by any component. However, we can find processTopologicalChanges() (in TopologicalChangeProcessor) and propagateTopologicalChanges (in multiple components).

agpetit commented 6 years ago

in BaseMaterial, handleTopologyChange() is copied but empty

hugtalbot commented 4 years ago

is this issue to be considered for STC#10 @epernod ?

hugtalbot commented 3 years ago

shall we close it @epernod ?

epernod commented 3 years ago

shall we close it @epernod ?

no it is my todo list!