sofastack / sofa-rpc-node

SOFARPC Node is a high-performance, high-extensibility, production-level Nodejs RPC framework.
MIT License
612 stars 64 forks source link

fix: print err if encoder/decoder error #101

Closed killagu closed 1 year ago

killagu commented 1 year ago

pump will destroy socket, if destroy socket in cb again. it will do nothing and error whil not print.

fengmk2 commented 1 year ago

ci 挂了,应该少了 close on error 逻辑,这个要看看。

killagu commented 1 year ago

是日志打印的条件漏加了。已经补上了。

codecov[bot] commented 1 year ago

Codecov Report

Merging #101 (166acef) into master (1921e7d) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   98.31%   98.27%   -0.05%     
==========================================
  Files          38       38              
  Lines        2311     2313       +2     
  Branches      367      368       +1     
==========================================
+ Hits         2272     2273       +1     
- Misses         39       40       +1     
Impacted Files Coverage Δ
lib/server/connection.js 97.43% <100.00%> (-1.25%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fengmk2 commented 1 year ago

2.3.1