search

sofastack / sofa-rpc-node

SOFARPC Node is a high-performance, high-extensibility, production-level Nodejs RPC framework.
MIT License
612 stars 64 forks source link

fix: zk registry bug #41

Closed gxcsoccer closed 5 years ago

gxcsoccer commented 5 years ago

close https://github.com/alipay/sofa-rpc-node/issues/33

codecov[bot] commented 5 years ago

Codecov Report

Merging #41 into master will decrease coverage by 0.04%. The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #41      +/-   ##
=========================================
- Coverage   98.55%   98.5%   -0.05%     
=========================================
  Files          38      38              
  Lines        1871    1877       +6     
=========================================
+ Hits         1844    1849       +5     
- Misses         27      28       +1
Impacted Files Coverage Δ
lib/registry/zk/index.js 100% <100%> (ø) :arrow_up:
lib/registry/zk/data_client.js 94.87% <80%> (-0.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5e2a84...4572d8e. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #41 into master will decrease coverage by 0.09%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #41     +/-   ##
=========================================
- Coverage   98.46%   98.37%   -0.1%     
=========================================
  Files          38       38             
  Lines        1890     1905     +15     
=========================================
+ Hits         1861     1874     +13     
- Misses         29       31      +2
Impacted Files Coverage Δ
lib/client/metric/rolling_counter.js 100% <ø> (ø) :arrow_up:
lib/client/connection/grpc/call_stream.js 92.12% <ø> (ø) :arrow_up:
lib/client/connection_mgr.js 96.87% <ø> (ø) :arrow_up:
lib/server/server.js 100% <ø> (ø) :arrow_up:
lib/server/connection.js 98.11% <ø> (ø) :arrow_up:
lib/server/grpc/response.js 97.43% <100%> (-0.07%) :arrow_down:
lib/registry/zk/index.js 100% <100%> (ø) :arrow_up:
lib/server/service.js 100% <100%> (ø) :arrow_up:
lib/registry/zk/data_client.js 94.91% <83.33%> (-0.63%) :arrow_down:
lib/registry/base.js 87.5% <0%> (-12.5%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2439e1e...98d3528. Read the comment docs.

gxcsoccer commented 5 years ago

wait https://github.com/node-modules/zookeeper-cluster-client/pull/10

gxcsoccer commented 5 years ago

sofa-rpc-node@1.11.0