codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.43%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   98.42%   97.99%   -0.44%     
==========================================
  Files          38       38              
  Lines        1908     1943      +35     
==========================================
+ Hits         1878     1904      +26     
- Misses         30       39       +9

Impacted Files	Coverage Δ
lib/client/request.js	`100% <100%> (ø)`	:arrow_up:
lib/client/consumer.js	`95.57% <70.58%> (-4.43%)`	:arrow_down:
lib/client/connection/rpc.js	`97.46% <76.47%> (-2.54%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 654c25c...6fe7750. Read the comment docs.

gxcsoccer commented 5 years ago

这个功能应该做到 connection 这个库吧？做到 sofa-rpc-node 里感觉怪怪的

killagu commented 5 years ago

那这个我迁到 connection 里面去吧。

sofastack / sofa-rpc-node

feat: implement oneway invoke #44

Codecov Report