search

sofastack / sofa-rpc-node

SOFARPC Node is a high-performance, high-extensibility, production-level Nodejs RPC framework.
MIT License
612 stars 64 forks source link

fix grpc bug #45

Closed RabbitSion closed 5 years ago

RabbitSion commented 5 years ago

修复grpc server 处理数据较大的http2请求时，多次触发data事件，导致Buffer.concat([ undefined ])的错误

codecov[bot] commented 5 years ago

Codecov Report

Merging #45 into master will increase coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #45     +/-   ##
=========================================
+ Coverage   98.42%   98.53%   +0.1%     
=========================================
  Files          38       38             
  Lines        1908     1908             
=========================================
+ Hits         1878     1880      +2     
+ Misses         30       28      -2
Impacted Files Coverage Δ
lib/server/grpc/server.js 98.43% <100%> (+1.56%) :arrow_up:
lib/client/connection/grpc/call_stream.js 92.72% <0%> (+0.6%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 654c25c...458eac4. Read the comment docs.

gxcsoccer commented 5 years ago

thanks for PR

gxcsoccer commented 5 years ago

1.12.1