softScheck / tplink-smartplug

TP-Link WiFi SmartPlug Client and Wireshark Dissector
Apache License 2.0
1.13k stars 296 forks source link

bad argument #2 to 'Proto' #100

Open jimlynnjulian opened 2 years ago

jimlynnjulian commented 2 years ago

Using portable vesion of latest Wireshark: -- --" line #27 - bad argument #2 to 'Proto' (Proto: there cannot be two protocols with the same description)" -- tried Proto.new() with extra space deleted. - No change. p_tplink = Proto ("TPLink-SmartHome","TP-Link Smart Home Protocol") I'm guessing the software environment has changed in the last six years. If so, close this.

holden144 commented 1 year ago

Changed p_tplink = Proto ("TPLink-SmartHome","TP-Link Smart Home Protocol") to p_tplink = Proto ("TPLink-SmartHome1","TP-Link Smart Home Protocol1")

This error is no longer thrown but no packets are shown.

patienttruth commented 1 month ago

My conclusion about this is that this plugin was integrated into Wireshark at some point. That's why there is an error about two protocols with the same description.

https://www.wireshark.org/docs/dfref/t/tplink-smarthome.html

I can't confirm this, but it's a lead.

patienttruth commented 1 month ago

I take it back! Try changing the name and description in the .lua file to whatever you want. Than search for that name as a filter in Wire Shark. I'm not sure how or why a filter with the same name got added to Wire Shark, but with the built in filter I wasn't getting decryption/dissection of the messages. When I used the protocol filter with the name I modified in the .lua file I got a full display of the packet.