Closed jacob-hughes closed 4 years ago
Out of curiosity, what other types did you try marking as NoFinalize
?
bors r+
Out of curiosity, what other types did you try marking as NoFinalize?
Those were the only ones that I could identify as valid candidates (other, more obvious types were already covered by needs_drop
)
bors ping
pong
Hmm, I'm not sure why bors didn't run earlier. Let's try again...
bors r+
Build succeeded:
This PR adds support for yksom to be used with rustc_boehm. If rustc_boehm is used to build yksom, the
rustc_boehm
feature flag can be passed to enable additional optimizations. E.g.:cargo build --release --features "rustc_boehm"
I've identified two types in yksom which will benefit from the
NoFinalize
marker trait inrustc_boehm
:Block
; andString_
. With that in place, we perform a lot better than ToT in the rebench suite: