software-challenge / gui

Software-Challenge GUI since 2020/21
https://software-challenge.de
10 stars 3 forks source link

GUI sends moves to all previously created games #57

Closed anarchuser closed 3 years ago

anarchuser commented 4 years ago

I created a few new Games (using the Ctrl+N shortcut), Human-Human. Then I wanted to place a piece. The corresponding SetMove was sent out several times to different room IDs in quick succession:

12:27:36 DEBUG sc.networking.clients.XStreamClient - Client sc.networking.clients.LobbyClient@3461614e: Sending RoomPacket(roomId=2ae8094b-8169-4e5e-94f2-4f65b532cd97, data=BLUE Piece PENTO_T:2 [0,17]) via TcpNetwork{socket=Socket[addr=localhost/127.0.0.1,port=13050,localport=45898]}
12:27:36 DEBUG sc.networking.clients.XStreamClient - Client sc.server.network.Client@113c51fe: Received RoomPacket(roomId=2ae8094b-8169-4e5e-94f2-4f65b532cd97, data=BLUE Piece PENTO_T:2 [0,17]) via TcpNetwork{socket=Socket[addr=/127.0.0.1,port=45898,localport=13050]}
12:27:36 DEBUG sc.networking.clients.XStreamClient - Client sc.networking.clients.LobbyClient@5ff30637: Sending RoomPacket(roomId=4efc7500-a8d5-4ca9-bd71-3007cba048a3, data=BLUE Piece PENTO_T:2 [0,17]) via TcpNetwork{socket=Socket[addr=localhost/127.0.0.1,port=13050,localport=45910]}
12:27:36 DEBUG sc.networking.clients.XStreamClient - Client sc.networking.clients.LobbyClient@65835484: Sending RoomPacket(roomId=c1c2b02d-6214-4fa3-9f3d-b10168242ff4, data=BLUE Piece PENTO_T:2 [0,17]) via TcpNetwork{socket=Socket[addr=localhost/127.0.0.1,port=13050,localport=45924]}
12:27:36 DEBUG sc.networking.clients.XStreamClient - Client sc.server.network.Client@404a77c: Received RoomPacket(roomId=4efc7500-a8d5-4ca9-bd71-3007cba048a3, data=BLUE Piece PENTO_T:2 [0,17]) via TcpNetwork{socket=Socket[addr=/127.0.0.1,port=45910,localport=13050]}
12:27:36 DEBUG sc.networking.clients.XStreamClient - Client sc.networking.clients.LobbyClient@47d2099a: Sending RoomPacket(roomId=b8f31ee6-dc8a-4f4a-8c2e-89e23a875c07, data=BLUE Piece PENTO_T:2 [0,17]) via TcpNetwork{socket=Socket[addr=localhost/127.0.0.1,port=13050,localport=45904]}

As response I've got a rule violation error back for every move sent except the last (which was actually valid). They GUI received these errors and stopped the Game: image

SKoschnicke commented 4 years ago

Happens as soon as on the second game which is started on the GUI if the first is not played to the end.

SKoschnicke commented 4 years ago

Might be related to #36

xeruf commented 3 years ago

Should be fixed by https://github.com/CAU-Kiel-Tech-Inf/gui/commit/a762fea63f18742577d817eed04aa36f7b1396a1