software-engineering-amsterdam / ST2017_WG_4

0 stars 0 forks source link

Feedback Lab 6 #11

Open ana-oprescu opened 7 years ago

ana-oprescu commented 7 years ago
Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Total
8 Good Job. However, the code is kind of confusing, whey you did not use the MultM function provided? 8 Good analysis. However some statistical analysis would make it better 9 Why not starting in 4? Since you know that 2 and 3 are not composites 7 Very good, can be improved by continuing the test even after finding the first false positive, and printing all the found false positives 6 Analysis is ok. In your analysis/experiments you are not taking into account that a Carmichael number N fools the Fermat test if you check aˆ(N−1) for some a that is coprime with N. An analysis/test on that direction is needed 6 ->issues 6 ->issues 10 ->issues 8.142857143