software-engineering-amsterdam / ST2017_WG_4

0 stars 0 forks source link

Feedback Lab 2 #4

Open hdmeyer opened 7 years ago

hdmeyer commented 7 years ago
Group # Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Total
4 9 Good solution: no timing 9 Good solution: no timing 4 -> Issues 6 Test report and time missing.What does testNotPermutationSingle? 4 isPermutation is wrong. Why not using isPermutation of 4? 7 Why the argument n in shift if elsewhere 26 is already hardcoded. No specification but a lot of interesting tests 8 Good Implementation, but lacks of time reporting and more extensive testing 0   6.71
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --