Open thisisgit opened 1 month ago
Hi,
I found that FlatList from RNGH accepts renderScrollComponent but it gets overwritten by its internal implementation https://github.com/software-mansion/react-native-gesture-handler/blob/f0dfef28b2de2b2ec479f86732120b2bf2c2506b/src/components/GestureComponents.tsx#L119-L127
FlatList
renderScrollComponent
Since it doesn't warn or notify user that this prop isn't supported, I think it's better to omit the prop just like what reanimated did to CellRendererComponent of Animated.FlatList.
CellRendererComponent
Animated.FlatList
Found this issue from https://github.com/kirillzyusko/react-native-keyboard-controller/issues/505
n/a
2.16.1
0.74.2
iOS
Hermes
Expo managed workflow
Paper (Old Architecture)
Debug mode
iOS simulator
No response
Yes
Hey! 👋
The issue doesn't seem to contain a minimal reproduction.
Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?
Description
Hi,
I found that
FlatList
from RNGH acceptsrenderScrollComponent
but it gets overwritten by its internal implementation https://github.com/software-mansion/react-native-gesture-handler/blob/f0dfef28b2de2b2ec479f86732120b2bf2c2506b/src/components/GestureComponents.tsx#L119-L127Since it doesn't warn or notify user that this prop isn't supported, I think it's better to omit the prop just like what reanimated did to
CellRendererComponent
ofAnimated.FlatList
.Found this issue from https://github.com/kirillzyusko/react-native-keyboard-controller/issues/505
Steps to reproduce
n/a
Snack or a link to a repository
n/a
Gesture Handler version
2.16.1
React Native version
0.74.2
Platforms
iOS
JavaScript runtime
Hermes
Workflow
Expo managed workflow
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
iOS simulator
Device model
No response
Acknowledgements
Yes