software-mansion / react-native-svg

SVG library for React Native, React Native Web, and plain React web projects.

MIT License

7.52k stars 1.14k forks source link

feat: Support `fontFeatureSettings` on web #2463

Open qwertychouskie opened 2 months ago

qwertychouskie commented 2 months ago

Summary

Support is just a matter of making sure we pass through the value properly. Hopefully the property is supported on iOS soon, but for now, 2 (Android + web) out of 3 is better than 1 out of 3.

Test Plan

Ran change locally, worked fine. It's a pretty trivial change.

What's required for testing (prerequisites)?

An SVG with fontFeatureSettings set on a Text element

What are the steps to reproduce (after prerequisites)?

Open browser
See that fontFeatureSettings is not applied
Apply this change
See that fontFeatureSettings is applied properly

Compatibility

OS	Implemented
iOS	❌
MacOS	❓
Android	✅
Web	✅

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added documentation in README.md
[x] I updated the typed files (typescript)
[ ] I added a test for the API in the __tests__ folder

bohdanprog commented 2 months ago

Hello @qwertychouskie, Thank you for your involvement in developing the library. Could you please provide an example of how we can check if it works? Here is my example where I tried to check how it works.