sojeri / howsTheWeatherSeattle

Seattle, how's the weather right now?
https://sojeri.github.io/howsTheWeatherSeattle
2 stars 0 forks source link

update moon phase handling #6

Open sojeri opened 5 years ago

sojeri commented 5 years ago

consider the following partial blob returned from an API call:

{
   "moonPhase":"Waning Gibbous",
   "moonIllumination":0.9913326951713101
}

moonIllumination is very nearly full, while moonPhase is waning gibbous. should this be considered full? while the API is correct this is technically a waning gibbous-- there's a reason that some cultures consider the full moon to last for 3 days. it looks full.

some thresholds to play with:

will keep an eye on API responses the next couple days & make a judgment call on this.

another option here would be to:

sojeri commented 5 years ago

v1 of this is in, but it needs to be verified

https://github.com/sojeri/howsTheWeatherSeattle/commit/4873027242c8d0ac877034bdc112a6dbe315c700

sojeri commented 1 year ago

based on creeping on the moon tonight vs the widget, the current full moon threshold needs to be increased somewhat. it looked full but showed 3/4.