search

solankimihir / VaccineAvailability

This is a simple front-end Javascript app that lets you watch vaccine availability on CoWin using Setu API
GNU General Public License v2.0
1 stars 1 forks source link

Major refactor; added fields for vaccine name, fee type, and fee amount #3

Closed misterbastean closed 1 year ago

misterbastean commented 3 years ago

Did a major refactor of the JS. Fixed broken query functionality. Added requested fields. Removed automatic refreshing, though it would be easy to add back in if desired (though it's not very good user experience). Refactored styles into CSS file and did very minor updates. Further work should be done to expand the districtMap const to include more districts and their numbers.

solankimihir commented 3 years ago

I had made changes in the original repo after you made a fork. So I resolved that conflict.

misterbastean commented 3 years ago

Made changes, see if I got them all.

One thing to note is that I'm getting very inconsistent results from the API. Responses often have 0 items in the "sessions" array, and I am also experiencing frequent network connection errors (though this is possibly due to the VPN).

solankimihir commented 3 years ago

Made changes, see if I got them all.

One thing to note is that I'm getting very inconsistent results from the API. Responses often have 0 items in the "sessions" array, and I am also experiencing frequent network connection errors (though this is possibly due to the VPN).

I will review it in evening and then merge the request.

Regarding 0 results in API response, it could be because of the fact that API Calls are made over and above the limit of 100 calls per 5 min interval. Confirm if you get Status OK (200) in such responses?

misterbastean commented 3 years ago

Believe all issues resolved, take a look when you get a chance.