solarwinds / OrionSDK

SDK for the SolarWinds Orion platform, including tools, documentation, and samples in PowerShell, C#, Go, Perl, and Java.
https://thwack.com/OrionSDK
Apache License 2.0
401 stars 144 forks source link

Add Filtering based on obsolete metadata. Filtering code refactoring. #188

Closed gglogowski closed 5 years ago

gglogowski commented 5 years ago

This pull request covers support for visualization of obsolete API in SWQL Studio:

It also covers refactoring of filtering (code is split to smaller classes)

nothrow commented 5 years ago

Nice work.

nothrow commented 5 years ago

Just one question - would it work with older SWIS (that has no concept of Obsolete property)?

gglogowski commented 5 years ago

Just one question - would it work with older SWIS (that has no concept of Obsolete property)?

Yes, It will work. It is handled in SwisMetaDataProvider, if obsolete meta data is not available in swis model, it is not queried and default value is used.