Updated format of most csproj files

solarwinds / OrionSDK

SDK for the SolarWinds Orion platform, including tools, documentation, and samples in PowerShell, C#, Go, Perl, and Java.

https://thwack.com/OrionSDK

Apache License 2.0

401 stars 144 forks source link

Updated format of most csproj files #198

Closed danjagnow closed 4 years ago

danjagnow commented 5 years ago

Updated the format of most csproj files:

SolarWinds.InformationService.Contract.csproj
InformationService.Contract.Tests.csproj
SwisPowerShell.csproj
SwisPowerShell.Tests.csproj

Switched from packages.config to PackageReference. Did not convert SwqlStudio.csproj (Windows Forms, not targeting .NET Core) or SolarWinds.Logging.csproj (may replace).

nothrow commented 5 years ago

Whats the benefit of doing this? (I would understand benefit of moving everything)

danjagnow commented 5 years ago

Two primary benefits:

Minimizes merge conflicts since .cs files are no longer explicitly listed in the .csproj files.
Shorter, easier-to-read *.csproj files.

nothrow commented 5 years ago

We would probably benefit the most from converting SwqlStudio as well. (.net core3?)

nothrow commented 5 years ago

Anyway, I was able to convert even the winforms .csproj, and it seems to work:

https://github.com/solarwinds/OrionSDK/tree/feature/project-modernization-all