search

soldair / node-qrcode

qr code generator
MIT License
7.55k stars 630 forks source link

[Request] Add a DEMO page. #146

Open mesqueeb opened 6 years ago

mesqueeb commented 6 years ago

Other QR code generators in JavaScript have less stars than you, but do have demo pages:

I'd love your page to also have a demo page, so that I can test out if everything works before deciding to implement your library.

Thank you very much!! : )

soldair commented 6 years ago

i do have a demo page in the repo somewhere. thanks for the suggestion.

vicjohnson1213 commented 5 years ago

Pulling this back from the dead.. I've modified the existing clientside demo to be a little more responsive and was wondering if you'd want to add it as an actual demo page?

Here's the demo page: https://vicjohnson1213.github.io/node-qrcode/

At the moment I have my changes on my gh-pages branch for publishing, but it could also be kept inside the /docs folder of the master branch if that's preferred.

soldair commented 5 years ago

@vicjohnson1213 im super happy to defer to what you think here.

maybe we can have it in docs and in gh-pages? tbh i've never published anything to github pages so happy to have you tell me how you think it should be done to help folks use this package

soldair commented 5 years ago

ooh and then maybe it can output code for you folks can copy paste from a text area!

vicjohnson1213 commented 5 years ago

Since the full clientside example requires the built qrcode.js and qrcode.tosjis.js files it's probably not the best practice to have them on the master branch. If you want to create a gh-pages branch I'll put up a PR to it.

I'll also make a PR to master updating the clientside example to match the gh-pages branch.