search

sole / Animated_GIF

Javascript library for creating animated GIFs
https://sole.github.io/Animated_GIF
225 stars 53 forks source link

Fixed define check #4

Closed operatorjen closed 10 years ago

operatorjen commented 10 years ago

This was breaking on chatspaces, but this fix works!

operatorjen commented 10 years ago

second commit relates to a dom exception that was being created because width/height were set to 0 even though they were already set on https://github.com/sole/Animated_GIF/blob/master/src/Animated_GIF.js#L9

since width/height are already set in the scope, it probably doesn't need to be passed in through addFrame as arguments for setSize. this also got rid of my dom exception error on chatspaces.

sole commented 10 years ago

I'm not going to merge it because you're changing the API (for bad), but I'm going to port the proper define statement, have a look at chatspaces to ensure the GIF part is properly initialised, and review the API to ensure it's clearly documented too. My bad for not doing so before :-(