solid-contrib / data-modules

Solid Data Modules
5 stars 1 forks source link

[contacts] pinned requirement is hard to install #99

Closed michielbdejong closed 1 month ago

michielbdejong commented 3 months ago

If you first do npm install rdflib and then npm install @solid-data-modules/contacts-rdflib it fails, because it will install rdflib@2.2.34-1 which does not meet the peer dependency of rdflib@"^2.2.33"

$ npm install rdflib @solid-data-modules/contacts-rdflib
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: sample-solid-app@1.0.0
npm ERR! Found: rdflib@2.2.34-1
npm ERR! node_modules/rdflib
npm ERR!   rdflib@"^2.2.34-1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rdflib@"^2.2.33" from @solid-data-modules/contacts-rdflib@0.5.0
npm ERR! node_modules/@solid-data-modules/contacts-rdflib
npm ERR!   @solid-data-modules/contacts-rdflib@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

You can fix this with:

npm remove rdflib
npm install rdflib @solid-data-modules/contacts-rdflib
angelo-v commented 3 months ago

I thought the caret is tolerant about patch versions, need to check, it should not be this way

angelo-v commented 3 months ago

@michielbdejong Do you know why rdflib "2.2.34-1" contains the "-1" suffix. I think this way it is considered incompatible with "^2.2.33". A rdflib version of "2.2.34" should work in my understanding.

angelo-v commented 3 months ago

After reading more about it I think this is actually the better solution https://github.com/solid-contrib/data-modules/pull/101

angelo-v commented 1 month ago

This should be fixed, if you still run into problems let me know